From 7a931cba8cc8289f56d0b9b3ddd0cfcfcc3149b7 Mon Sep 17 00:00:00 2001 From: Rui Chen Date: Thu, 21 Dec 2023 13:33:49 -0500 Subject: [PATCH 1/8] feat: bump nvmrc and engine constraint to node 20 Signed-off-by: Rui Chen --- .nvmrc | 2 +- package.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.nvmrc b/.nvmrc index 39514a97..d5a15960 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -12.22.4 +20.10.0 diff --git a/package.json b/package.json index 6558d803..b57ababc 100644 --- a/package.json +++ b/package.json @@ -4,8 +4,8 @@ "description": "GitHub Actions for Hugo", "main": "lib/index.js", "engines": { - "node": ">=16.18.0", - "npm": ">=8.19.0" + "node": ">=20.10.0", + "npm": ">=10.2.3" }, "scripts": { "all": "npm run format:check && npm run lint && npm test", From 0baec7d13a93717764c6c9d60d184666414bade7 Mon Sep 17 00:00:00 2001 From: Rui Chen Date: Thu, 21 Dec 2023 13:39:34 -0500 Subject: [PATCH 2/8] feat: update to use nodejs20 runtime Signed-off-by: Rui Chen --- .github/workflows/test-action.yml | 1 - .github/workflows/test.yml | 10 +++------- README.md | 5 ++--- action.yml | 2 +- package-lock.json | 6 +++--- 5 files changed, 9 insertions(+), 15 deletions(-) diff --git a/.github/workflows/test-action.yml b/.github/workflows/test-action.yml index eeae154a..da5cf745 100644 --- a/.github/workflows/test-action.yml +++ b/.github/workflows/test-action.yml @@ -11,7 +11,6 @@ jobs: strategy: matrix: os: - - 'ubuntu-22.04' - 'ubuntu-20.04' - 'ubuntu-latest' - 'macos-latest' diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a61b1f06..407437c1 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -24,14 +24,10 @@ jobs: steps: - uses: actions/checkout@v4 - - name: Read .nvmrc - run: echo "::set-output name=NVMRC::$(cat .nvmrc)" - id: nvm - - - name: Setup Node - uses: actions/setup-node@v3.6.0 + - uses: actions/setup-node@v4 with: - node-version: '${{ steps.nvm.outputs.NVMRC }}' + node-version-file: '.nvmrc' + cache: 'npm' - run: npm ci diff --git a/README.md b/README.md index 407439fb..856dfebd 100644 --- a/README.md +++ b/README.md @@ -261,10 +261,9 @@ jobs: hugo-version: '0.119.0' extended: true - - name: Setup Node - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: - node-version: '18' + node-version: '20' cache: 'npm' # The action defaults to search for the dependency file (package-lock.json, # npm-shrinkwrap.json or yarn.lock) in the repository root, and uses its diff --git a/action.yml b/action.yml index 30db7381..8dcf0cb2 100644 --- a/action.yml +++ b/action.yml @@ -11,7 +11,7 @@ inputs: required: false default: 'false' runs: - using: 'node16' + using: 'node20' main: 'lib/index.js' branding: icon: 'package' diff --git a/package-lock.json b/package-lock.json index c8385c42..f7c54653 100644 --- a/package-lock.json +++ b/package-lock.json @@ -6,7 +6,7 @@ "packages": { "": { "name": "actions-hugo", - "version": "2.5.0", + "version": "2.6.0", "hasInstallScript": true, "license": "MIT", "dependencies": { @@ -36,8 +36,8 @@ "typescript": "^4.2.3" }, "engines": { - "node": ">=16.18.0", - "npm": ">=8.19.0" + "node": ">=20.10.0", + "npm": ">=10.2.3" } }, "node_modules/@actions/core": { From d5ef30d6410a845bb33fd23ed3fbe460d8463e04 Mon Sep 17 00:00:00 2001 From: Rui Chen Date: Thu, 21 Dec 2023 13:47:26 -0500 Subject: [PATCH 3/8] update @types/node to v20 Signed-off-by: Rui Chen --- package-lock.json | 36 +++++++++++++++++++++++++++--------- package.json | 2 +- 2 files changed, 28 insertions(+), 10 deletions(-) diff --git a/package-lock.json b/package-lock.json index f7c54653..82cb35d0 100644 --- a/package-lock.json +++ b/package-lock.json @@ -18,7 +18,7 @@ }, "devDependencies": { "@types/jest": "^26.0.20", - "@types/node": "~12", + "@types/node": "~20", "@types/node-fetch": "^2.5.8", "@typescript-eslint/eslint-plugin": "^4.16.1", "@typescript-eslint/parser": "^4.16.1", @@ -1620,10 +1620,13 @@ "dev": true }, "node_modules/@types/node": { - "version": "12.12.67", - "resolved": "https://registry.npmjs.org/@types/node/-/node-12.12.67.tgz", - "integrity": "sha512-R48tgL2izApf+9rYNH+3RBMbRpPeW3N8f0I9HMhggeq4UXwBDqumJ14SDs4ctTMhG11pIOduZ4z3QWGOiMc9Vg==", - "dev": true + "version": "20.10.5", + "resolved": "https://registry.npmjs.org/@types/node/-/node-20.10.5.tgz", + "integrity": "sha512-nNPsNE65wjMxEKI93yOP+NPGGBJz/PoN3kZsVLee0XMiJolxSekEVD8wRwBUBqkwc7UWop0edW50yrCQW4CyRw==", + "dev": true, + "dependencies": { + "undici-types": "~5.26.4" + } }, "node_modules/@types/node-fetch": { "version": "2.5.8", @@ -12067,6 +12070,12 @@ "node": ">=0.8.0" } }, + "node_modules/undici-types": { + "version": "5.26.5", + "resolved": "https://registry.npmjs.org/undici-types/-/undici-types-5.26.5.tgz", + "integrity": "sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA==", + "dev": true + }, "node_modules/union-value": { "version": "1.0.1", "resolved": "https://registry.npmjs.org/union-value/-/union-value-1.0.1.tgz", @@ -13943,10 +13952,13 @@ "dev": true }, "@types/node": { - "version": "12.12.67", - "resolved": "https://registry.npmjs.org/@types/node/-/node-12.12.67.tgz", - "integrity": "sha512-R48tgL2izApf+9rYNH+3RBMbRpPeW3N8f0I9HMhggeq4UXwBDqumJ14SDs4ctTMhG11pIOduZ4z3QWGOiMc9Vg==", - "dev": true + "version": "20.10.5", + "resolved": "https://registry.npmjs.org/@types/node/-/node-20.10.5.tgz", + "integrity": "sha512-nNPsNE65wjMxEKI93yOP+NPGGBJz/PoN3kZsVLee0XMiJolxSekEVD8wRwBUBqkwc7UWop0edW50yrCQW4CyRw==", + "dev": true, + "requires": { + "undici-types": "~5.26.4" + } }, "@types/node-fetch": { "version": "2.5.8", @@ -22177,6 +22189,12 @@ "dev": true, "optional": true }, + "undici-types": { + "version": "5.26.5", + "resolved": "https://registry.npmjs.org/undici-types/-/undici-types-5.26.5.tgz", + "integrity": "sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA==", + "dev": true + }, "union-value": { "version": "1.0.1", "resolved": "https://registry.npmjs.org/union-value/-/union-value-1.0.1.tgz", diff --git a/package.json b/package.json index b57ababc..e83ce2be 100644 --- a/package.json +++ b/package.json @@ -55,7 +55,7 @@ }, "devDependencies": { "@types/jest": "^26.0.20", - "@types/node": "~12", + "@types/node": "~20", "@types/node-fetch": "^2.5.8", "@typescript-eslint/eslint-plugin": "^4.16.1", "@typescript-eslint/parser": "^4.16.1", From 92277398fa5fe67eabacb6ba2fc4ccbf31f6f423 Mon Sep 17 00:00:00 2001 From: Rui Chen Date: Thu, 21 Dec 2023 13:47:45 -0500 Subject: [PATCH 4/8] bump version to 3.0.0 per nodejs20 upgrade Signed-off-by: Rui Chen --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index e83ce2be..4f737f39 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "actions-hugo", - "version": "2.6.0", + "version": "3.0.0", "description": "GitHub Actions for Hugo", "main": "lib/index.js", "engines": { From b616c0b741969b59833c4607a752264c5b9ea8de Mon Sep 17 00:00:00 2001 From: Rui Chen Date: Fri, 22 Dec 2023 01:00:09 -0500 Subject: [PATCH 5/8] chore: update ncc to latest Signed-off-by: Rui Chen --- package-lock.json | 18 +++++++++--------- package.json | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/package-lock.json b/package-lock.json index 82cb35d0..29c4066c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "actions-hugo", - "version": "2.6.0", + "version": "3.0.0", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "actions-hugo", - "version": "2.6.0", + "version": "3.0.0", "hasInstallScript": true, "license": "MIT", "dependencies": { @@ -22,7 +22,7 @@ "@types/node-fetch": "^2.5.8", "@typescript-eslint/eslint-plugin": "^4.16.1", "@typescript-eslint/parser": "^4.16.1", - "@vercel/ncc": "^0.27.0", + "@vercel/ncc": "^0.38.1", "eslint": "^7.21.0", "eslint-plugin-jest": "^24.1.5", "husky": "^5.1.3", @@ -1876,9 +1876,9 @@ } }, "node_modules/@vercel/ncc": { - "version": "0.27.0", - "resolved": "https://registry.npmjs.org/@vercel/ncc/-/ncc-0.27.0.tgz", - "integrity": "sha512-DllIJQapnU2YwewIhh/4dYesmMQw3h2cFtabECc/zSJHqUbNa0eJuEkRa6DXbZvh1YPWBtYQoPV17NlDpBw1Vw==", + "version": "0.38.1", + "resolved": "https://registry.npmjs.org/@vercel/ncc/-/ncc-0.38.1.tgz", + "integrity": "sha512-IBBb+iI2NLu4VQn3Vwldyi2QwaXt5+hTyh58ggAMoCGE6DJmPvwL3KPBWcJl1m9LYPChBLE980Jw+CS4Wokqxw==", "dev": true, "bin": { "ncc": "dist/ncc/cli.js" @@ -14125,9 +14125,9 @@ } }, "@vercel/ncc": { - "version": "0.27.0", - "resolved": "https://registry.npmjs.org/@vercel/ncc/-/ncc-0.27.0.tgz", - "integrity": "sha512-DllIJQapnU2YwewIhh/4dYesmMQw3h2cFtabECc/zSJHqUbNa0eJuEkRa6DXbZvh1YPWBtYQoPV17NlDpBw1Vw==", + "version": "0.38.1", + "resolved": "https://registry.npmjs.org/@vercel/ncc/-/ncc-0.38.1.tgz", + "integrity": "sha512-IBBb+iI2NLu4VQn3Vwldyi2QwaXt5+hTyh58ggAMoCGE6DJmPvwL3KPBWcJl1m9LYPChBLE980Jw+CS4Wokqxw==", "dev": true }, "abab": { diff --git a/package.json b/package.json index 4f737f39..e9ea0251 100644 --- a/package.json +++ b/package.json @@ -59,7 +59,7 @@ "@types/node-fetch": "^2.5.8", "@typescript-eslint/eslint-plugin": "^4.16.1", "@typescript-eslint/parser": "^4.16.1", - "@vercel/ncc": "^0.27.0", + "@vercel/ncc": "^0.38.1", "eslint": "^7.21.0", "eslint-plugin-jest": "^24.1.5", "husky": "^5.1.3", From 194ee8263dde669230c6a8080b8471289b4c94ae Mon Sep 17 00:00:00 2001 From: Rui Chen Date: Fri, 22 Dec 2023 01:01:18 -0500 Subject: [PATCH 6/8] chore: no fail-fast for CI builds Signed-off-by: Rui Chen --- .github/workflows/test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 407437c1..b3f6e3c6 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -14,6 +14,7 @@ jobs: test: runs-on: ${{ matrix.os }} strategy: + fail-fast: false matrix: os: - 'ubuntu-22.04' From 6ed77e143065c5aaa0de2ce436d97445d29cf316 Mon Sep 17 00:00:00 2001 From: Rui Chen Date: Fri, 22 Dec 2023 01:18:45 -0500 Subject: [PATCH 7/8] update branch trigger to test the worklow runs in fork Signed-off-by: Rui Chen --- .github/workflows/test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b3f6e3c6..679ae1dc 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -4,6 +4,7 @@ on: push: branches: - main + - node20 paths-ignore: - '**.md' pull_request: From 2135c0ad4fd617b70b16c77addb0fd7ae3874aa6 Mon Sep 17 00:00:00 2001 From: Rui Chen Date: Fri, 22 Dec 2023 01:20:46 -0500 Subject: [PATCH 8/8] Revert "update branch trigger to test the worklow runs in fork" This reverts commit 6ed77e143065c5aaa0de2ce436d97445d29cf316. --- .github/workflows/test.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 679ae1dc..b3f6e3c6 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -4,7 +4,6 @@ on: push: branches: - main - - node20 paths-ignore: - '**.md' pull_request: