Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: update node to a more recent version #642

Closed
3 tasks done
retorquere opened this issue Jan 25, 2024 · 9 comments
Closed
3 tasks done

proposal: update node to a more recent version #642

retorquere opened this issue Jan 25, 2024 · 9 comments
Assignees
Labels
proposal Feature request resolved resolved issue

Comments

@retorquere
Copy link

Checklist

  • I am using the latest version of this action.
  • I have read the latest README and followed the instructions.
  • I have read the latest GitHub Actions official documentation and learned the basic spec and concepts.

Describe your proposal

update node to a more recent version. GHA is reporting that node 16 actions are deprecated

Describe the solution you'd like

An update to a newer node version

Describe alternatives you've considered

Manually installing hugo

Additional context

None

@retorquere retorquere added the proposal Feature request label Jan 25, 2024
@tohn
Copy link

tohn commented Jan 26, 2024

Got this warning as well:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: peaceiris/actions-hugo@v2.6.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

I think #641 does exactly that? And #614 is obsolete now 😉

@retorquere
Copy link
Author

I think #641 does exactly that?

Seems like it does.

@daviddavo
Copy link

But we still need a release so github action's picks it up automatically

@jesseadams
Copy link

@peaceiris Can we please get a new release?

@ricomariani
Copy link

ricomariani commented Mar 8, 2024

UPDATE: peaceiris/actions-hugo@v3 is now available, do not use the workaround below.

Lacking a release and with the deadline looming I made a fork and published a release with the release.sh script:

I am now able to do this:

uses: ricomariani/actions-hugo@sha-deleted-for-your-safety-use-the-release-above

This works for me but it won't be maintained further. If you're stuck you can use it. I don't know if there are known bugs in 'main' on the maintained branch but if main is good enough for you there's a published release now.

pryrt added a commit to notepad-plus-plus/npp-usermanual that referenced this issue Mar 28, 2024
`peaceiris/actions-hugo#642 also mentioned `peaceiris/actions-hugo#641, which was merged to main branch as `https://github.com/peaceiris/actions-hugo/commit/c57490a8b04136ae58ab5866a93d3db2f0fa0945`; the implication is that `@c57490a8b04136ae58ab5866a93d3db2f0fa0945` may be able to reference that internal commit
@peaceiris
Copy link
Owner

#647 (comment)

@ricomariani
Copy link

peaceiris/actions-hugo@v3 is working for me. I removed the SHA in my comment above so nobody will use it by accident. I will likely delete my fork in a few weeks just in case someone is still using the workaround SHA.

@peaceiris
Copy link
Owner

Thank you so much @ricomariani!

@peaceiris peaceiris added the resolved resolved issue label Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

This issue has been LOCKED because of it being resolved!

The issue has been fixed and is therefore considered resolved.
If you still encounter this or it has changed, open a new issue instead of responding to solved ones.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
proposal Feature request resolved resolved issue
Projects
None yet
Development

No branches or pull requests

6 participants