Reduce scope of middleware exception handling #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steventux
force-pushed
the
reduce-scope-of-middleware-exception-handling
branch
3 times, most recently
from
fd5bc9f
to
f603240
Compare
|
@steventux Test please :) |
Limits the handling of exceptions to those occurring in the PDF generation logic, handling errors from @app.call(env) has the side-effect of burying errors which may be raised legitimately by other middlewares.
steventux
force-pushed
the
reduce-scope-of-middleware-exception-handling
branch
from
f603240
to
d60904e
Compare
|
@serene 👍 I've added a test here now d60904e#diff-115284d51cd4c5774a89ff4272da74a4R410-R418 |
serene
approved these changes
Jul 8, 2020
|
It would be possible to release a new version with this? 0.8.4.3.1 is catching application exceptions... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the scope of exception handling to the PDF generation logic in the middleware.
The call to
@app.call(env)should be able to raise exceptions as these may be legitimate errors from applications or other middlewares.We noticed that in development mode, our application errors were being obfuscated and caught by the rescue statement for the entire middleware, this appears to be because we also trap errors coming via
@app.call(env).cc @serene - I believe this relates to the review conversation we had here #469 (review) please let me know if you need more information.