Response status is unmodified by exceptions in middleware

[steventux]

When an exception occurs in PDFKit middleware the response status does not reflect this.

https://github.com/pdfkit/pdfkit/blob/master/lib/pdfkit/middleware.rb#L20-L53

We discovered this issue recently, our specs test the response code of a PDF generating path, but a mis-configuration of our application middleware(s) meant the response body was compressed before PDFKit attempted to transform it. This resulted in an application error but the response status code was 200.

This PR #469 attempts to remedy this by returning a 500 response status code if exceptions are encountered when transforming the response into PDF.

[github-actions]

This issue has been marked as stale and will be automatically closed.