Improve path detection fallback #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarthod
commented
Jan 23, 2020
jarthod
commented
Jan 23, 2020
jarthod
commented
Jan 23, 2020
|
This pull request has been marked as stale and will be automatically closed. |
|
☹ |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion in #123 (comment) this is the MR to improve path detection resilience by falling back to
whichwhenbundle exec whichis failing (which happens with some bundler version).I've added specs for all the cases I thought about and improved a bit the current specs which where dependent on using bundler to run rspec, now they mock bundler presence so the result is reliable whether we start rspec with bundler or not.
Feel free if you have any questions. I'm thinking there's most probably a more standard / reliable way to get the path of a binary using Bundler methods instead of shelling out, but I'd rather not risk more changes here.