From dfed7949c3714dceb0318e4381f00e7fb5d5dfe3 Mon Sep 17 00:00:00 2001 From: pbludov Date: Sat, 18 Jan 2020 13:28:40 +0300 Subject: [PATCH] minor: add missing test case to SuperCloneCheckTest --- .../checkstyle/checks/coding/SuperCloneCheckTest.java | 1 + .../superclone/InputSuperClonePlainAndSubclasses.java | 11 ++++++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SuperCloneCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SuperCloneCheckTest.java index 522ecc2bab0..c6393a027bd 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SuperCloneCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SuperCloneCheckTest.java @@ -62,6 +62,7 @@ public void testAnotherInputFile() throws Exception { final DefaultConfiguration checkConfig = createModuleConfig(SuperCloneCheck.class); final String[] expected = { + "43:17: " + getCheckMessage(MSG_KEY, "clone", "super.clone"), "9:17: " + getCheckMessage(MSG_KEY, "clone", "super.clone"), }; verify(checkConfig, getPath("InputSuperClonePlainAndSubclasses.java"), expected); diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/coding/superclone/InputSuperClonePlainAndSubclasses.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/coding/superclone/InputSuperClonePlainAndSubclasses.java index 25d4a6a7fc0..5ffc5c64e32 100644 --- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/coding/superclone/InputSuperClonePlainAndSubclasses.java +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/coding/superclone/InputSuperClonePlainAndSubclasses.java @@ -6,7 +6,7 @@ interface InputSuperClonePlainAndSubclasses { } class A { - public Object clone() { + public Object clone() { // violation return null; } } @@ -37,3 +37,12 @@ public void run() { }; } } + +class D extends B { + + public Object clone() throws CloneNotSupportedException { // violation + super.clone(null, null); + return null; + } + +}