Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript import strategy #265

Closed
hahnlee opened this issue Dec 8, 2022 · 2 comments
Closed

TypeScript import strategy #265

hahnlee opened this issue Dec 8, 2022 · 2 comments

Comments

@hahnlee
Copy link

hahnlee commented Dec 8, 2022

Hello. First of all, thank you for making a good library.

It would be nice to have the following features.
As a decision of the TypeScript team, import statements must import with the ".js" extension in ESM mode, and no extension in other modes. (microsoft/TypeScript#37582)

It seems that TypeScript 5.0 is considering importing with a .ts extension, but currently it gives a warning. (microsoft/TypeScript#51362)

Considering Deno, it should have the .ts extension, so I'd appreciate it if you'd consider the opt-out feature.

etc.

  1. As described above, in tsc's ESM mode, it must be imported as .js. Would it be better to implement this feature?
  2. If agree that the feature is needed, is it okay for me to participate in the implementation?
@hahnlee hahnlee changed the title Typescript import strategy TypeScript import strategy Dec 8, 2022
@hahnlee
Copy link
Author

hahnlee commented Dec 8, 2022

--ext-in-import=" " Ah... there was this 😅

@hahnlee hahnlee closed this as completed Dec 8, 2022
@disjukr
Copy link
Member

disjukr commented Dec 8, 2022

Thank you for your interest in pbkit. We have a Discord community, how about joining in? You'll get a quicker answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants