Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DBUP ExecutionTimeout to be set #233

Closed
jakeduddy opened this issue Jan 17, 2023 · 3 comments
Closed

Allow DBUP ExecutionTimeout to be set #233

jakeduddy opened this issue Jan 17, 2023 · 3 comments

Comments

@jakeduddy
Copy link

jakeduddy commented Jan 17, 2023

"Connection Timeout" can be set for connection setting to SQL server but DBUP has a default timeout of 30s, which doesn't seem to be adjustable with PBI-Tools. A parameter to be sent from .pbixproj.json would allow more complex scripts to be executed.

https://github.com/pbi-tools/pbi-tools/blob/main/src/PBI-Tools/Deployments/SqlScriptsDeployer.cs
Function: BuildUpgradeEngine + engineBuilder.WithExecutionTimeout(TimeSpan.FromMinutes(5));

@mthierba
Copy link
Contributor

mthierba commented Jan 17, 2023

The Microsoft .Data.SqlClient Command Timeout connection string property (https://github.com/dotnet/SqlClient/blob/2c2f100d8ab9a1f6ee8c048a260d77e6a738e1e7/release-notes/2.1/2.1.0-preview2.md#command-timeout-connection-string-property) does not do the job?
In dbup, the timeout is only overwritten if specified, otherwise the underlying provider's timeout kicks in, I believe:

https://github.com/DbUp/DbUp/blob/cc439e28add976c057d680c903b80e089d288c7a/src/dbup-core/Support/ScriptExecutor.cs#L131

@jakeduddy
Copy link
Author

"Command Timeout" does indeed work, was using "Connection Timeout"

@mthierba
Copy link
Contributor

ref: dotnet/SqlClient#722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants