Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize funding RPC if channel open > 1 #35

Open
DanGould opened this issue Oct 27, 2022 · 3 comments
Open

Parallelize funding RPC if channel open > 1 #35

DanGould opened this issue Oct 27, 2022 · 3 comments

Comments

@DanGould
Copy link
Contributor

we don't need repeat rpc calls, which I think we're doing now.

lnd: https://api.lightning.community/#batchopenchannel

cln: https://lightning.readthedocs.io/lightning-multifundchannel.7.html

@Kixunil
Copy link
Contributor

Kixunil commented Nov 17, 2022

batchopenchannel doesn't allow PSBT funding flow so it's incompatible with PayJoin.

@DanGould
Copy link
Contributor Author

In that case we could still make The LndClient Sync and Send so the "Verify funding" logic can interact with remote lightning nodes in parallel lnd::LndClient::verify_funding as demonstrated in #10

@DanGould DanGould reopened this Nov 21, 2022
@DanGould DanGould changed the title Use batch funding RPC if channel open > 1 Parallelize funding RPC if channel open > 1 Nov 21, 2022
@Kixunil
Copy link
Contributor

Kixunil commented Nov 21, 2022

Oh, yes, definitely! I was thinking about it before. It was POC code after all. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants