Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting an attribute error on m1 mac #791

Open
mielsense opened this issue Feb 6, 2023 · 2 comments · May be fixed by #801
Open

Getting an attribute error on m1 mac #791

mielsense opened this issue Feb 6, 2023 · 2 comments · May be fixed by #801
Labels
bug Something isn't working

Comments

@mielsense
Copy link

What happened?

Getting : AttributeError: module 'term_image.image' has no attribute 'TermImage'
as an error, everytime i try to run

nbpreview version

0.9.1

Output

AttributeError: module 'term_image.image' has no attribute 'TermImage'

Notebook

any notebook

OS

macOs

Terminal

any terminal (fish shell)

Python version

3.9.6
@mielsense mielsense added the bug Something isn't working label Feb 6, 2023
@paw-lu
Copy link
Owner

paw-lu commented Feb 21, 2023

looks like term_image upgraded it's api, and nbpreview is using the old one. i'll pin the dependencies first as a quick fix, then later upgrade the code to use the new api

thanks for flagging!

lebedov added a commit to lebedov/nbpreview that referenced this issue Mar 28, 2023
@lebedov
Update to address term_image API change (paw-lu#791)
f0bfe02
@lebedov lebedov linked a pull request Mar 28, 2023 that will close this issue
Open
@mrestof-vre
Copy link

I fixed it for myself. Is the solution still needed? The pull-request above is a little bit wrong.
If anyone gonna hack this for themselves too, just two notes: TermImage is now created via BlockImage (subclass of BaseImage), maxsize was redefined as frame_size. For details check this link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to account for changes in term image api lebedov/nbpreview
3 participants
@paw-lu @mielsense @mrestof-vre