Diesel 2 feature support #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables
diesel 2.0.0-rc.1support via two new feature flags:db-diesel2-mysqlanddb-diesel2-postgres. In fact, to make things easierdieselfeatures are now explicit (i.e.db-diesel1-*) with a backwards compatible feature flag pointing to version1.4.Another notable change is that because of uncertainty building both
diesel1anddiesel2at the same time, I explicitly include a compiler error if both features are enabled.Subsequently, the build system needed to relax during the first build step. It built using
--all-featureshowever due to complexities with Serde configuration etc it was admittedly a little pointless. Sadly though, I can't use--all-featuresonclippyanymore - though as a future change I made move this to the makefile and process feature by feature. It'd be nice ifcargoallowed you to exclude features as that way we could avoid conflicting features.Anyway, this closes #531 and replaces #512 (though thank you for the quick and easy updates I could apply!)