Fix Decimal::to_i64 for I64::MIN #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paupino
reviewed
Mar 19, 2022
| @@ -2127,14 +2127,14 @@ impl ToPrimitive for Decimal { | |||
| fn to_i64(&self) -> Option<i64> { | |||
| let d = self.trunc(); | |||
| // Quick overflow check | |||
| if d.hi != 0 || (d.mid & 0x8000_0000) > 0 { | |||
There was a problem hiding this comment.
This is close, but isn't quite right either I don't think. I think we need to check explicitly for i64::MIN since that is the value which is unable to be represented.
I'll write a couple more tests and contribute to this PR.
paupino
added a commit
that referenced
this pull request
Mar 19, 2022
Co-authored-by: Paul Mason <paul@paulmason.me> Co-authored-by: Arthur Silva <arthurprs@gmail.com>
|
Merged manually in 2de2a6d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overflow check didn't consider that the maximum mantissa for negative numbers can use the extra bit.