Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TryFrom impls to primitive types #493

Merged
merged 3 commits into from
Mar 18, 2022
Merged

Add TryFrom impls to primitive types #493

merged 3 commits into from
Mar 18, 2022

Conversation

turion
Copy link
Contributor

@turion turion commented Mar 15, 2022 •
edited by paupino

Fixes #492

@turion turion mentioned this pull request Mar 15, 2022
Closed
paupino
paupino reviewed Mar 15, 2022
View reviewed changes
Copy link
Owner

@paupino paupino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits in here, but namely because we'll be introducing a new interface. Getting it "mostly" right early is easier than changing it later!

src/decimal.rs Outdated Show resolved Hide resolved
src/decimal.rs Outdated Show resolved Hide resolved
src/decimal.rs Outdated Show resolved Hide resolved
src/decimal.rs Outdated Show resolved Hide resolved
src/decimal.rs Outdated Show resolved Hide resolved
tests/decimal_tests.rs Outdated Show resolved Hide resolved
@turion turion requested a review from paupino March 16, 2022 14:59
paupino
paupino reviewed Mar 17, 2022
View reviewed changes
src/decimal.rs Outdated Show resolved Hide resolved
@paupino paupino enabled auto-merge (squash) March 17, 2022 16:04
auto-merge was automatically disabled March 17, 2022 17:32

Head branch was pushed to by a user without write access

@paupino
Copy link
Owner

paupino commented Mar 17, 2022

@turion You should be able to resolve the style issues by running makers format (this runs cargo fmt -- --emit=files behind the scenes).

@turion
Copy link
Contributor Author

turion commented Mar 18, 2022

The trouble here seems to be that cargo fmt isn't idempotent here! I've run cargo fmt already, and amended the change, but it always wants to indent once more.

@paupino
Copy link
Owner

paupino commented Mar 18, 2022

Oh, of course. I know how to fix that. I'll add it and merge manually.

@paupino paupino enabled auto-merge (squash) March 18, 2022 17:20
@paupino paupino merged commit 168fa67 into paupino:master Mar 18, 2022
@paupino paupino changed the title Add TryFrom impls to primitive types (#492) Add TryFrom impls to primitive types Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paupino paupino paupino left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trait to convert from a Decimal
2 participants
@turion @paupino