Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing #4

Open
pozsa opened this issue Nov 9, 2021 · 5 comments
Open

Contributing #4

pozsa opened this issue Nov 9, 2021 · 5 comments
Assignees
Labels
question Further information is requested

Comments

@pozsa
Copy link
Member

pozsa commented Nov 9, 2021

This issue is meant to document our development practices, git workflow and other related topics. We should add these items to the repo in the form of a contributing guide.

@sbliven
Copy link
Member

sbliven commented Nov 10, 2021

I suggest

  • black and flake8 for formatting
  • pytest and tox for testing
  • sphinx with myst-parser (markdown) for docs
  • github actions for CI

I usually just use setuptools for packaging, but I'd be open to trying something newer (e.g. poetry).

@pozsa
Copy link
Member Author

pozsa commented Nov 10, 2021

I'm ok with everything you mentioned above.
I would add isort and mypy.
For packaging, I'd use docker, but I like the idea of using poetry for python dep management.

@pozsa
Copy link
Member Author

pozsa commented Nov 10, 2021

Have you seen this https://github.com/github/super-linter? I suggest we hook it up and disable pylint.

@sbliven
Copy link
Member

sbliven commented Nov 11, 2021

Yes to all of that

@pozsa
Copy link
Member Author

pozsa commented Nov 15, 2021

How thorough do we want to be with docstrings? E.g. do we want pydocstyle?

@pozsa pozsa added the question Further information is requested label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants