Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] migrate tests to Github Actions #469

Merged
merged 4 commits into from Apr 29, 2021
Merged

Conversation

ljharb
Copy link
Collaborator

@ljharb ljharb commented Apr 29, 2021

Per ljharb/object.assign#81

travis-ci's new pricing plan, and its defaults, have caused all my ljharb repos to have zero CI whatsoever until December. @travis-ci Support is MIA, so I unfortunately can't rely on it as a service anymore.

@paulmillr
Copy link
Owner

Allow all actions is set

@ljharb
Copy link
Collaborator Author

ljharb commented Apr 29, 2021

I'm very confused why the PR isn't triggering an actions run :-/ it's running on my fork: https://github.com/ljharb/es6-shim/runs/2470213815

@ljharb
Copy link
Collaborator Author

ljharb commented Apr 29, 2021

@paulmillr is there an "approve and run" button showing for you on the PR status box?

@paulmillr
Copy link
Owner

@ljharb I think it will only show after the merge

@ljharb
Copy link
Collaborator Author

ljharb commented Apr 29, 2021

That has not been my experience - pull_request_target workflows behave like that, but most of these are pull_request, and should work immediately.

You can see all the hundreds of PRs I linked to ljharb/object.assign#81 running on the first PR.

@paulmillr
Copy link
Owner

perhaps it depends on repo owner, which is different in your repos. let's try merging it, we can always revert

@ljharb
Copy link
Collaborator Author

ljharb commented Apr 29, 2021

I'd prefer to hold off; I'm pinging github folks about it: https://github.community/t/pr-adding-actions-not-running-jobs/177497

I'll land the PR once they confirm it's a bug, or working as intended, but they might need the PR left open to debug it.

@ljharb
Copy link
Collaborator Author

ljharb commented Apr 29, 2021

Figured it out; I had to land at least one action in the default branch first to "enable" actions (which seems like a clear bug).

I'll land this once the tests pass.

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@ad15fce). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #469   +/-   ##
=========================================
  Coverage          ?   86.05%           
=========================================
  Files             ?        2           
  Lines             ?     2352           
  Branches          ?      607           
=========================================
  Hits              ?     2024           
  Misses            ?      328           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad15fce...8d44bc1. Read the comment docs.

@ljharb ljharb merged commit 8d44bc1 into paulmillr:master Apr 29, 2021
@ljharb ljharb deleted the travis branch April 29, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants