Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when prototype.js is present #441

Open
dimaslz opened this issue Apr 24, 2017 · 5 comments
Open

Issue when prototype.js is present #441

dimaslz opened this issue Apr 24, 2017 · 5 comments

Comments

@dimaslz
Copy link

dimaslz commented Apr 24, 2017

Hi, I have a problem with es6-shim when is using prototype.js.

Basically the code is a widget that is injecting in the website. I using es6-shim to fix a compatibility with IE11, but we have a client that is using prototype.js 1.7 https://ajax.googleapis.com/ajax/libs/prototype/1.7.0/prototype.js in the site and we have a conflict:

screen shot 2017-04-24 at 10 58 04

To do this widget, we are using https://github.com/KoryNunn/crel to create the html and next minify in only one file.

If I use "es6-shim", the widget works in all browsers, but If I remove the "es6-shim" the the script do not work in IE11, but if we use "es6-shim" and in the site is using prototype.js, the script do not work in any browser.

I test with last version of prototype.js (1.7.3.0)
https://ajax.googleapis.com/ajax/libs/prototype/1.7.3.0/prototype.js and there another error:
screen shot 2017-04-24 at 11 22 27

But only I need to solve for 1.7!

Can you help me with some tip?, I wish to know some opinion.

Thanks you community!

@dimaslz
Copy link
Author

dimaslz commented Apr 24, 2017

Written this, I take the solution. xd

@dimaslz dimaslz closed this as completed Apr 24, 2017
@ljharb
Copy link
Collaborator

ljharb commented Apr 24, 2017

@dimaslz what was your solution?

@ljharb
Copy link
Collaborator

ljharb commented Apr 24, 2017

prototype.js is obsolete, but I still want the es6-shim to work with it.

@dimaslz
Copy link
Author

dimaslz commented Apr 25, 2017

@ljharb Yes, I know that is obsolete, but is a special case.

So the solution, I used babel-polyfill and works properly. With es6-shim I have problem, I don't know way. But don't care, will improve a lot thing soon.

Thanks!

@ljharb
Copy link
Collaborator

ljharb commented Apr 25, 2017

@dimaslz could you provide me with a jsfiddle that reproduces the problem?

@ljharb ljharb reopened this Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants