Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise ES6 Construct (Promise,Map,Set) to follow latest spec #303

Open
ljharb opened this issue Nov 18, 2014 · 5 comments
Open

Revise ES6 Construct (Promise,Map,Set) to follow latest spec #303

ljharb opened this issue Nov 18, 2014 · 5 comments

Comments

@ljharb
Copy link
Collaborator

ljharb commented Nov 18, 2014

https://github.com/paulmillr/es6-shim/blob/master/es6-shim.js#L161-L174 no longer applies, since as of Rev 28 @@create no longer exist.

Should we thus remove this function?

@domenic
Copy link

domenic commented Nov 18, 2014

Subclassing is still supported though.

@ljharb
Copy link
Collaborator Author

ljharb commented Nov 18, 2014

Definitely - how can we shim the act of calling the [[CreateAction]] internal slot?

@cscott
Copy link
Collaborator

cscott commented Nov 18, 2014

Yeah, it needs to stay there until I revise the Promise implementation to follow the latest spec. Our @@create methods were used to ensure that Map and Set etc also support subclassing; we need to come up with a unified solution for that. Probably with a hidden field named literally [[CreateAction]] or something like that.

In the meantime, I think having the correct externally-visible operation (as we do now) is more important than whether our implementation follows the naming of spec-internal methods. Unless someone can point to a concrete externally-visible ES6 behavior that we are misbehaving on?

@ljharb
Copy link
Collaborator Author

ljharb commented Nov 18, 2014

Relates to #239.

ljharb added a commit to ljharb/es6-shim that referenced this issue Jan 5, 2015
@ljharb ljharb changed the title @@create no longer exists Revise Promise to follow latest spec Jan 5, 2015
@ljharb
Copy link
Collaborator Author

ljharb commented Jan 5, 2015

@cscott any update on this one?

@cscott cscott changed the title Revise Promise to follow latest spec Revise ES6 Construct (Promise,Map,Set) to follow latest spec Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants