Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security vulnerability CVE-2019-20149 #971

Closed
RedMickey opened this issue Jan 17, 2020 · 4 comments
Closed

Fix security vulnerability CVE-2019-20149 #971

RedMickey opened this issue Jan 17, 2020 · 4 comments

Comments

@RedMickey
Copy link

Hello, I'm a member the development team of VS Code extensions for debugging Cordova and React Native applications. Several vulnerabilities were revealed in chokidar package dependencies. The package causing a security issue is kind-of. Detailed info about CVE-2019-20149 vulnerability is available here. The vulnerability has been already fixed. It's recommended to update outdated dependencies.

@paulmillr
Copy link
Owner

What are you talking about? Chokidar doesn't depend on kind-of.

@RedMickey
Copy link
Author

@paulmillr, oh now I see, that was our fault. It seems that there was a mistake in our audit tools. Sorry for bothering you.

@edwardgalligan
Copy link

edwardgalligan commented Mar 16, 2020

What are you talking about? Chokidar doesn't depend on kind-of.

@paulmillr @RedMickey chokidar does depend on kind-of.

I see the following listed in chokidar's package.json file

  • "anymatch": "~3.1.1", depends on kind-of
  • "braces": "~3.0.2", depends on kind-of
  • "readdirp": "~3.3.0" depends on kind-of

Pretty worrying to see a CVE so rapidly dismissed on such a popular package.

@paulmillr
Copy link
Owner

@edwardgalligan bullshit. Do your research. I take security very seriously.

Anymatch has 2 dependencies:

https://www.npmjs.com/package/picomatch
https://www.npmjs.com/package/normalize-path

Each of those have 0 dependencies. No kind-of.

Braces has one dep fill-range, which has one dep to-regex-range, which has one dep is-number.

Readdirp has only picomatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants