This repository has been archived by the owner on Mar 15, 2021. It is now read-only.
Allow overrides to be nil
#318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a problem where attribute methods would be treated as missing when their override value was set to `nil`. Instead of relying on the value of the attribute, this commit changes the behavior to use `fetch` on the attributes hash. Only a truly missing attribute will now trigger the `super` call in `method_missing`.
|
Looks great! Thank you! |
|
Just released 2.21.1 with this change. Thanks again! |
|
Thanks for the fast turnaround! Much appreciated 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where attribute methods would be treated as missing when their override value was set to
nil.Instead of relying on the value of the attribute, this commit changes the behavior to use
fetchon the attributes hash. Only a truly missing attribute will now trigger thesupercall inmethod_missing.