This repository has been archived by the owner on Mar 15, 2021. It is now read-only.
Verify that ActiveRecord::Base is defined when checking for support #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some gems will create an ActiveRecord module, but if you aren't using AR you won't have AR::Base loaded. The check breaks in this case.
|
Nice catch! Thanks! |
|
Just pushed version 2.20.2 with this fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some gems will create an
ActiveRecordmodule, but if youaren't using already using AR you won't have AR::Base loaded.
The previous check would throw an exception in that scenrio.
I've modified the check to detect that
ActiveRecord::Baseis also defined.