Skip to content

fix(Chip): spread fewer props #8584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2023
Merged

fix(Chip): spread fewer props #8584

merged 2 commits into from
Jan 23, 2023
+36 −22

Conversation

nicolethoen
Copy link
Contributor

What: Closes #8583

@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 23, 2023 •
edited
Loading

Preview: https://patternfly-react-pr-8584.surge.sh

A11y report: https://patternfly-react-pr-8584-a11y.surge.sh

dlabrecq
dlabrecq approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@dlabrecq dlabrecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a snapshot needs to be updated, but looks ok otherwise

@tlabaj tlabaj merged commit b43a524 into patternfly:main Jan 23, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@4.82.111
  • @patternfly/react-core@4.276.4
  • @patternfly/react-docs@5.103.59
  • @patternfly/react-inline-edit-extension@4.86.116
  • demo-app-ts@4.210.4
  • @patternfly/react-table@4.112.37
  • @patternfly/react-topology@4.91.24
  • @patternfly/react-virtualized-extension@4.88.111

Thanks for your contribution! 🎉

@nicolethoen nicolethoen deleted the fix_chip_prop_spreading branch February 8, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlabrecq dlabrecq

@tlabaj tlabaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - Chip - props causing console errors
4 participants
@nicolethoen @patternfly-build @dlabrecq @tlabaj