Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabButton, TabContent, ToolbarGroup props missing from docs #4197

Closed
jenny-s51 opened this issue May 6, 2020 · 2 comments · Fixed by #4249
Closed

TabButton, TabContent, ToolbarGroup props missing from docs #4197

jenny-s51 opened this issue May 6, 2020 · 2 comments · Fixed by #4249
Assignees

Comments

@jenny-s51
Copy link
Contributor

jenny-s51 commented May 6, 2020

Describe the issue. What is the expected and unexpected behavior?

Extends #3885 and @mturley's comment there:

Probably related to the fact that it is exported as a forwardRef component.

Originally posted by @mturley in #3885 (comment)

These are all exported as forwardRefs and their props are also not being displayed in the docs.

@redallen
Copy link
Contributor

redallen commented May 7, 2020

This is a react-docgen issue we might be able to work around. The source code for what we use is upstream in patternfly-org: https://github.com/patternfly/patternfly-org/blob/master/packages/gatsby-transformer-react-docgen-typescript/gatsby-node.js#L102

We really should contribute to react-docgen if we can't find a workaround.

@mturley
Copy link
Collaborator

mturley commented May 11, 2020

This is one of a few things I'd like to see us fix in react-docgen. I think it might be worth meeting at some point to share some knowledge about how we use it and how it works, so we can more easily figure out what changes we need to propose for it. I'm curious if anyone else in the TS React community is also looking for changes like that in react-docgen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants