Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal: Deprecate modal #8078

Open
tlabaj opened this issue Sep 26, 2022 · 0 comments · May be fixed by #10358
Open

Modal: Deprecate modal #8078

tlabaj opened this issue Sep 26, 2022 · 0 comments · May be fixed by #10358
Assignees
@thatblindgeye
Labels
breaking change 💥 this change requires a major release and has API changes. DevX enhances the consumer developer experience but does not change the experience for the end-user md PF6
Milestone
Penta beta release

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Sep 26, 2022 •
edited

Deprecate the modal

  • Move the Modal code to the deprecated directory (react-core\src\deprecated\). The documentation would show up under a "React deprecated" tab on the Modal page of the website.
  • Promote the "next Modal" to our default Modal component by moving it to react-core\src\components\.

related to #8076
@tlabaj tlabaj added breaking change 💥 this change requires a major release and has API changes. PF5 labels Sep 26, 2022
@tlabaj tlabaj added this to the 2022.16 milestone Sep 27, 2022
@mcarrano mcarrano modified the milestones: 2022.16, Breaking Changes Oct 26, 2022
@tlabaj tlabaj added the sm label Nov 4, 2022
@tlabaj tlabaj added md and removed sm labels Dec 7, 2022
@tlabaj tlabaj modified the milestones: Breaking Changes, 2023.04 Dec 7, 2022
@tlabaj tlabaj modified the milestones: 2023.04, Breaking Changes Dec 16, 2022
@nicolethoen nicolethoen removed the PF5 label Mar 7, 2023
@nicolethoen nicolethoen added the Feature end user feature that requires design to define this, i.e. changes or augments the user experience. label Apr 27, 2023
@mcarrano mcarrano added DevX enhances the consumer developer experience but does not change the experience for the end-user and removed Feature end user feature that requires design to define this, i.e. changes or augments the user experience. labels Jun 12, 2023
@srambach srambach added the PF6 label Apr 17, 2024
@thatblindgeye thatblindgeye linked a pull request May 13, 2024 that will close this issue
Open
@thatblindgeye thatblindgeye linked a pull request May 13, 2024 that will close this issue
feat(Modal): promoted next version #10358
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
breaking change 💥 this change requires a major release and has API changes. DevX enhances the consumer developer experience but does not change the experience for the end-user md PF6
Projects
PatternFly 5
Status: No status
PatternFly Issues
Status: PR Review
Milestone
Penta beta release
Development

Successfully merging a pull request may close this issue.

feat(Modal): promoted next version thatblindgeye/patternfly-react
5 participants
@mcarrano @srambach @nicolethoen @tlabaj @thatblindgeye