Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop cursor inconsistencies #10290

Open
Venefilyn opened this issue Apr 19, 2024 · 1 comment · Fixed by #10356 · May be fixed by #10357
Open

Drag and drop cursor inconsistencies #10290

Venefilyn opened this issue Apr 19, 2024 · 1 comment · Fixed by #10356 · May be fixed by #10357
Assignees

Comments

@Venefilyn
Copy link
Contributor

Please describe the issue
Looking at the drag and drop I see several different cursors I don't associate with a drag and drop

Are there visuals for this issue? Please provide screenshots
Include screenshots or links to Marvel or other mockups.

When hovering over the grab button there's a click rather than grab
image

Picking up looks correct here
image

But not when you select something else
image

Same if you select outside the text
image

When releasing the drag and drop here, it changes to grab hand which is correct, but given the other cursors being incorrect it doesn't fit
image

Could you point to a branch or draft PR where this issue exists? Please provide a link to the code
https://staging-v6.patternfly.org/components/drag-and-drop

Any other information?

@tlabaj
Copy link
Contributor

tlabaj commented May 2, 2024

We will remove the basic example without the drag button since that is not recommended. We will update the componet so the drag button variant is the default (prevent no drag button variant)
WE will need 2 PRs. one for v5 one for v6.

@tlabaj tlabaj added this to the 2024.Q2 milestone May 2, 2024
@kmcfaul kmcfaul self-assigned this May 8, 2024
@kmcfaul kmcfaul linked a pull request May 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment