Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update popover in Password Strength demo #10071

Closed
thatblindgeye opened this issue Feb 8, 2024 · 2 comments · Fixed by #10353
Closed

Update popover in Password Strength demo #10071

thatblindgeye opened this issue Feb 8, 2024 · 2 comments · Fixed by #10353
Assignees
@Dominik-Petrik
Labels
sm Tech debt improvements to code that do not affect either user or product developers’ experience.
Milestone
Prioritized Backlog

Comments

@thatblindgeye
Copy link
Contributor

Describe the enhancement or change
Currently the popover in the Password Strength has content related to mentioning password requirements. In general that sort of content shouldn't be hidden in a popover and instead displayed below the input, which the demo is already doing.

We should either remove the help popover or update its content to something more along the lines of "why does a strong password matter" or something along those lines.

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?
@thatblindgeye thatblindgeye added the Tech debt improvements to code that do not affect either user or product developers’ experience. label Feb 8, 2024
@tlabaj
Copy link
Contributor

tlabaj commented Feb 26, 2024

Let's remove the help icon and popover.

@thatblindgeye thatblindgeye mentioned this issue Feb 26, 2024
Closed
@tlabaj tlabaj added this to the Prioritized Backlog milestone Feb 26, 2024
@tlabaj tlabaj added the sm label Feb 26, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@Dominik-Petrik Dominik-Petrik self-assigned this May 10, 2024
@Dominik-Petrik Dominik-Petrik mentioned this issue May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dominik-Petrik Dominik-Petrik

Labels
sm Tech debt improvements to code that do not affect either user or product developers’ experience.
Projects
PatternFly Issues
Status: Done
Milestone
Prioritized Backlog
Development

Successfully merging a pull request may close this issue.

fix(PasswordStrength) remove popover in demo Dominik-Petrik/patternfly-react
3 participants
@tlabaj @thatblindgeye @Dominik-Petrik