Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wizard to remove reference to error color token #10335

Closed
Tracked by #10314
mcoker opened this issue May 2, 2024 · 2 comments · Fixed by #10378
Closed
Tracked by #10314

Update wizard to remove reference to error color token #10335

mcoker opened this issue May 2, 2024 · 2 comments · Fixed by #10378
Assignees

Comments

@mcoker
Copy link
Contributor

mcoker commented May 2, 2024

Follow up to patternfly/patternfly#6447

TL;DR

Vertical nav/step list

  • Adds new element span.pf-v6-c-wizard__nav-link-status-icon that is the first thing in .pf-v6-c-wizard__nav-link when there is an error on a step.
    • Technically this element will hold any status icon, but so far we only support error status.
    • We're using the "exclamation circle" icon there since the step numbers are also circles. I think we usually use exclamation triangle, so calling that out.
  • Adds span.pf-v6-c-wizard__nav-link-main that wraps everything else in .pf-v6-c-wizard__nav-link (.pf-v6-c-wizard__nav-link-text and .pf-v6-c-wizard__nav-link-toggle)
  • When a step has an error, .pf-v6-c-wizard__nav-link getc class .pf-m-danger

Mobile nav toggle

  • Adds new element span.pf-v6-c-wizard__toggle-status-icon that is the first thing in .pf-v6-c-wizard__toggle-list-item when the current step in the mobile nav toggle has an error
    • Same notes as the vertical nav notes above
  • When the current step has an error, the .pf-v6-c-wizard__toggle-list-item in .pf-v6-c-wizard__toggle gets class .pf-m-danger
@mcoker
Copy link
Contributor Author

mcoker commented May 2, 2024

cc @kmcfaul @tlabaj this is ready to work on and part of #10314

@kmcfaul kmcfaul self-assigned this May 7, 2024
@kmcfaul
Copy link
Contributor

kmcfaul commented May 7, 2024

Assigned this to myself and bringing this work in as part of the PR that will update the core version all together, since it will also require the core update to work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants