Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit completed templates for API consistency/refinement #10267

Open
Tracked by #10069
kmcfaul opened this issue Apr 10, 2024 · 1 comment · May be fixed by #10473
Open
Tracked by #10069

Revisit completed templates for API consistency/refinement #10267

kmcfaul opened this issue Apr 10, 2024 · 1 comment · May be fixed by #10473
Assignees
Milestone

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Apr 10, 2024

No description provided.

@kmcfaul kmcfaul mentioned this issue Apr 10, 2024
10 tasks
@kmcfaul kmcfaul self-assigned this Apr 10, 2024
@kmcfaul kmcfaul added this to the 2024.Q2 milestone May 7, 2024
@kmcfaul
Copy link
Contributor Author

kmcfaul commented May 20, 2024

  • IDs in templates should be customizable (they are static atm and will cause a11y issues if multiple are on the same page).
  • Add an example with descriptions on options (should already be possible by passing description to the option object as it extends SelectOptionProps).
  • Add toggleProps to spread to toggle (for style and other MenuToggle options) and maybe other spreadable prop options

We may also want to add an informational callback for the open state (something like isOpen: () => boolean). This may be necessary for templates within Modals because Modal needs to throw out an Escape keydown event if the child menu is open - but this may instead be an issue with Modal's keyboard handling.

Do we want to rename SelectBasic, SelectTypeahead, DropdownBasic to BasicSelect or Select, TypeaheadSelect, BasicDropdown or Dropdown? Mentioned because we do have CheckboxSelect, instead of SelectCheckbox.

@kmcfaul kmcfaul linked a pull request May 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PR Review
Development

Successfully merging a pull request may close this issue.

1 participant