Re-approach the design of the PF5 <Select> component

[KKoukiou]

In cockpit we decided on an early adoption of PF5 (https://cockpit-project.org/blog/patternfly-v5-alpha.html) and I am coming back here with some feedback.

The topic here will be the new <Select> component. All in all I find it a bit unnecessarily complicated as exposed to the consumers. Let's enumerate the parts that could be IMO simplified.

• SelectOption: right now itemId and children are required properties, otherwise the component will not render. This is asking the user to pass the same value twice for most of the simple cases. Additionally itemId feels like 'id', html dom element identifier. The old property name 'value' is more exact to what this is.

• MenuToggle component can be hidden from the consumers in the simple cases at least. Compared to the previous implementation which hided the MenuToggle from the users, now the users of this components need to write much more boilerplate code.

This includes:
Two places to define if the select menu is open:

•  MenuToggle isExpanded={isOpen}
  

•  Select isOpen={isOpen}
  

Three places to control the open state of the component

•  MenuToggle onClick={() => setIsopen(!isOpen)}   // Cotrols events that change the open state from the toggle itself
  

•  Select onSelect={onSelect} // Controls events that change the open state when clicking on options
  

•  onOpenChange={isOpen => setIsOpen(isOpen)}  // Controls events that change the open state externally, for example clicking outside of the component or pressing Esc
  

Let me know if you 're open to re-design this for a better consumer experience.

CC @nicolethoen @tlabaj