Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom resolver type #401

Merged
merged 1 commit into from Feb 10, 2022
Merged

Conversation

bespokebob
Copy link
Contributor

The custom resolver is allowed to return undefined (really, any falsy value) if a module is not found, but this type definition requires it to return a string. This fixes the definition to allow undefined.

The custom resolver is allowed to return undefined (really, any falsy value) if a module is not found, but this type definition requires it to return a string. This fixes the definition to allow undefined.
@XmiliaH XmiliaH merged commit b4d9dce into patriksimek:master Feb 10, 2022
@XmiliaH
Copy link
Collaborator

XmiliaH commented Feb 10, 2022

Thanks for the fix

@bespokebob
Copy link
Contributor Author

It doesn't look like this fix actually made it into 3.9.7. Did you publish from your repository or branch?

@XmiliaH
Copy link
Collaborator

XmiliaH commented Feb 11, 2022

Seems like I published my local branch. Sorry for that. This will be included in the next release.

@bespokebob bespokebob deleted the fix-resolver-type branch April 6, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants