Internal restructuring and security improvements #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! Thank you ❤️ |
xtx1130
reviewed
Jan 29, 2023
| cacheUtilScript = new VMScript(`return function inherits(ctor, superCtor) { | ||
| ctor.super_ = superCtor; | ||
| Object.setPrototypeOf(ctor.prototype, superCtor.prototype); | ||
| }`, {__proto__: null, filename: 'util.js'}); |
There was a problem hiding this comment.
setPrototypeOf(target, value) {
// Note: target@this(unsafe) throws@this(unsafe)
throw new VMError(OPNA);
}I have some questions about inherits:
- Why forbidden to use
inheritsin vm2? - As mentioned in the above code, why not just throw an exception but use
setPrototypeOfinstead
There was a problem hiding this comment.
This actually allows to use inherits in the sandbox. Without it would not work for sandboxed objects and would allow the sandbox to change the prototype chain of host objects passed into the sandbox. The code you copied will only be called when inherits is used on a host object where it should not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits large files into multiple for better maintainability. Furthermore, the
contextify.jsmodule was rewritten from scratch to handle RangeErrors in the correct context and be able to handle RangeErrors from the different context too.This also includes security improvements for NodeVM's require which had issues with options being circumvented with relative or absolute requires.