Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Edelman response function #475

Open
mbakker7 opened this issue Jan 20, 2023 · 2 comments
Open

Remove Edelman response function #475

mbakker7 opened this issue Jan 20, 2023 · 2 comments
Assignees
Labels
deprecation Indicates deprecations of older code priority 2 low, nice to have feature to be implemented when time's available
Milestone

Comments

@mbakker7
Copy link
Collaborator

The Edelman response function has been in the code for a while, but was never operational as it was not imported upon regular import of pastas.

The Edelman response function has problems, as it takes infinitely long before the step response reaches 1, and as a result it takes very long for it to reach the cutoff. Almost the same response can be obtained with the Polder function, which reaches 1 within a finite time.

I propose to remove the Edelman response function from the code base.

@mbakker7 mbakker7 added enhancement Indicates improvement of existing features bug Indicates an unintended behavior or coding error labels Jan 20, 2023
@rubencalje
Copy link
Collaborator

The Edelman function was proposed by Wilbert Berendrecht in 2019 (see your mail at the time), after which I committed it in Pastas. I experimented with it a bit at the time. The function is (or was) operational, but you can only reach it by pastas.rfunc.Edelman, and not directly by pastas.Edelman.

Wilbert maximized tmax at 20000, and he preferred it over the Polder-function, because the parameters of the Polder function were too correlated. Unless you think this is not true, or Edelman causes problems keeping the rest of pastas up to date, I am in favor of keeping it.

@raoulcollenteur raoulcollenteur added deprecation Indicates deprecations of older code and removed bug Indicates an unintended behavior or coding error enhancement Indicates improvement of existing features labels Feb 3, 2023
@martinvonk martinvonk changed the title [ENHANCEMENT]Remove Edelman response function [DEPRECATION] Remove Edelman response function Feb 27, 2023
@martinvonk martinvonk added the priority 2 low, nice to have feature to be implemented when time's available label Mar 7, 2023
@raoulcollenteur raoulcollenteur added this to the 1.3 milestone Aug 17, 2023
@raoulcollenteur raoulcollenteur modified the milestones: 1.3, 2.0: Bolognese Nov 28, 2023
@raoulcollenteur raoulcollenteur modified the milestones: 2.0: Bolognese, 1.5 Apr 9, 2024
@raoulcollenteur raoulcollenteur changed the title [DEPRECATION] Remove Edelman response function Remove Edelman response function Apr 12, 2024
@raoulcollenteur raoulcollenteur modified the milestones: 1.5, 1.6 Apr 17, 2024
@dbrakenhoff
Copy link
Member

Move to plugins when plugins API is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Indicates deprecations of older code priority 2 low, nice to have feature to be implemented when time's available
Projects
None yet
Development

No branches or pull requests

5 participants