Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Maximum Likelihood solver #364

Open
raoulcollenteur opened this issue Dec 30, 2021 · 7 comments
Open

Add a Maximum Likelihood solver #364

raoulcollenteur opened this issue Dec 30, 2021 · 7 comments
Assignees
Labels
development Indicates development of new features priority 2 low, nice to have feature to be implemented when time's available
Milestone

Comments

@raoulcollenteur
Copy link
Member

@mbakker7, is it an idea to move the LmFitSolverNew to a separate branch or remove it?

@raoulcollenteur raoulcollenteur added the enhancement Indicates improvement of existing features label Dec 30, 2021
@raoulcollenteur raoulcollenteur added this to the 0.20.0 milestone Dec 30, 2021
@mbakker7
Copy link
Collaborator

This is a first step to add a Maximum Likelihood Function as objective function.
It would be very useful to have that. Maybe we should change the name to MaxLikelihoodSolver.

@raoulcollenteur
Copy link
Member Author

That would indeed be very useful! I also have some scripts already we could merge into that. Going to remove this from the main branch and add it in a separate branch to keep things clean. Changed the title of this Issue.

@raoulcollenteur raoulcollenteur changed the title Remove LmFitSolverNew? Add a Maximum Likelihood solver Mar 23, 2022
@raoulcollenteur raoulcollenteur modified the milestones: 0.20.0, 0.21.0 Mar 23, 2022
@raoulcollenteur
Copy link
Member Author

Move LmfitSolveNew to a separate branch: https://github.com/pastas/pastas/tree/364-add-maximum-likelihood-solver

@dbrakenhoff
Copy link
Member

Not sure if this could be of any help, but metran uses a Kalman filter and maximum likelihood to optimize the model. It is a slightly different model for decomposing timeseries into specific and common components but could be useful as a reference...?

@raoulcollenteur raoulcollenteur self-assigned this Aug 16, 2022
@dbrakenhoff dbrakenhoff removed this from the 0.21.0 milestone Aug 16, 2022
@raoulcollenteur raoulcollenteur added this to the 0.22.0 milestone Aug 16, 2022
@raoulcollenteur raoulcollenteur modified the milestones: 1.0: Arrabiata, 1.1 Jan 31, 2023
@martinvonk martinvonk changed the title Add a Maximum Likelihood solver [DEVELOPMENT] Add a Maximum Likelihood solver Feb 27, 2023
@martinvonk martinvonk added development Indicates development of new features and removed enhancement Indicates improvement of existing features labels Feb 27, 2023
@martinvonk martinvonk added the priority 1 normal, deal with in the foreseeable future label Mar 7, 2023
@raoulcollenteur
Copy link
Member Author

@mbakker7, not sure if this is covered by #559 ? Actually #559 adds MCMC, which is different from a maximum likelihood solver where the negative log likelihood is minimised.

If #559 covers what you want and we don't want a maximum likelihood solver where the negative log likelihood is minimised, perhaps we can close this issue?

@mbakker7
Copy link
Collaborator

mbakker7 commented Mar 21, 2023

I propose to have a maxium likelihood solver separate from the MCMC. I guess this doesn't require much work as all that is needed is an objective function that is the negative maximium likelihood function. So rather than a solver it is an objective function. Maybe change the title of the issue?

@raoulcollenteur
Copy link
Member Author

Ok. Then we keep this issues alive. MLE might be easy to add with objective functions from #559, let's look at that after the finishing that one.

@raoulcollenteur raoulcollenteur removed this from the 1.1 milestone Mar 22, 2023
@raoulcollenteur raoulcollenteur added the priority 2 low, nice to have feature to be implemented when time's available label Mar 22, 2023
@martinvonk martinvonk removed the priority 1 normal, deal with in the foreseeable future label Aug 11, 2023
@raoulcollenteur raoulcollenteur added this to the 1.3 milestone Aug 17, 2023
@raoulcollenteur raoulcollenteur removed their assignment Sep 4, 2023
@raoulcollenteur raoulcollenteur modified the milestones: 1.3, 1.4 Nov 28, 2023
@raoulcollenteur raoulcollenteur modified the milestones: 1.4, 1.5 Feb 16, 2024
@raoulcollenteur raoulcollenteur changed the title [DEVELOPMENT] Add a Maximum Likelihood solver Add a Maximum Likelihood solver Apr 12, 2024
@raoulcollenteur raoulcollenteur modified the milestones: 1.5, 1.6 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Indicates development of new features priority 2 low, nice to have feature to be implemented when time's available
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants