-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Maximum Likelihood solver #364
Comments
This is a first step to add a Maximum Likelihood Function as objective function. |
That would indeed be very useful! I also have some scripts already we could merge into that. Going to remove this from the main branch and add it in a separate branch to keep things clean. Changed the title of this Issue. |
Move LmfitSolveNew to a separate branch: https://github.com/pastas/pastas/tree/364-add-maximum-likelihood-solver |
Not sure if this could be of any help, but metran uses a Kalman filter and maximum likelihood to optimize the model. It is a slightly different model for decomposing timeseries into specific and common components but could be useful as a reference...? |
@mbakker7, not sure if this is covered by #559 ? Actually #559 adds MCMC, which is different from a maximum likelihood solver where the negative log likelihood is minimised. If #559 covers what you want and we don't want a maximum likelihood solver where the negative log likelihood is minimised, perhaps we can close this issue? |
I propose to have a maxium likelihood solver separate from the MCMC. I guess this doesn't require much work as all that is needed is an objective function that is the negative maximium likelihood function. So rather than a solver it is an objective function. Maybe change the title of the issue? |
Ok. Then we keep this issues alive. MLE might be easy to add with objective functions from #559, let's look at that after the finishing that one. |
@mbakker7, is it an idea to move the LmFitSolverNew to a separate branch or remove it?
The text was updated successfully, but these errors were encountered: