Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of env over with for action configuration #68

Open
Geod24 opened this issue Apr 6, 2020 · 1 comment
Open

Usage of env over with for action configuration #68

Geod24 opened this issue Apr 6, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@Geod24
Copy link

Geod24 commented Apr 6, 2020

When setting up this action, I was surprised to see the configuration passed using env instead of with, as described in https://help.github.com/en/actions/building-actions/metadata-syntax-for-github-actions#inputs
In essence, it seems that the end result would be pretty much the same ("GitHub stores input parameters as environment variables." according to the doc), but the added bonus is that the input parameters can be documented at the action level (in action.yml).

@pascalgn
Copy link
Owner

pascalgn commented Apr 6, 2020

I think the reason is that this action was created before GH added the "with" feature to actions. As far as I know, there is no reason to keep "env", so I think it could make sense to migrate the configuration to use "with".

Feel free to provide a PR, if you like! 👍

@pascalgn pascalgn added the good first issue Good for newcomers label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants