Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Support PR co-authoring when squashing via commit description #196

Open
smoya opened this issue Sep 15, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@smoya
Copy link

smoya commented Sep 15, 2022

Using squash merging strategy ends up with only one commit being merged, being the author of it the person who created the PR.

This leads to lose authority of commits. All changes of such a PR will appear to be introduced by the person who created the PR.
In order to add co-authors to a commit, you need to add each of those as extra line in the description of the commit as mentioned in https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line.

It would be awesome if this action introduces support for this.

In the meantime, I made up a workaround by adding an extra step prior to this action. See asyncapi/.github#176

@smoya smoya changed the title [Feature request] Support PR co-authoring via commit description [Feature request] Support PR co-authoring when squashing via commit description Sep 15, 2022
@pascalgn pascalgn added the enhancement New feature or request label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants