Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for required reviews #160

Merged
merged 6 commits into from Sep 3, 2021
Merged

Add support for required reviews #160

merged 6 commits into from Sep 3, 2021

Conversation

stephtr
Copy link
Contributor

@stephtr stephtr commented Jun 14, 2021

This PR adds a new parameter, MERGE_REQUIRED_APPROVALS with which the minimal amount of required PR review approvals can be specified.

lib/api.js Outdated Show resolved Hide resolved
@pascalgn
Copy link
Owner

GH has this feature (require a certain amount of approvals) built-in:
image

Could you give some motivation for adding it to this action? 🙏

@stephtr
Copy link
Contributor Author

stephtr commented Jun 27, 2021

Thank you for your feedback!
My main motivation for this work (I already use it on my repos) is that the branch protection feature isn't included with GitHub's free organization accounts.
I'll try to address your comments within the next few days.

@stephtr
Copy link
Contributor Author

stephtr commented Aug 18, 2021

Sorry for the delay and thanks for the idea for the two changes! It's updated now.

@pascalgn pascalgn merged commit e7220c3 into pascalgn:main Sep 3, 2021
@pascalgn
Copy link
Owner

pascalgn commented Sep 3, 2021

Thanks for the PR, it's merged now! 🎉 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants