Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support workflow_run events #155

Closed
apexskier opened this issue May 22, 2021 · 2 comments · Fixed by #156
Closed

Support workflow_run events #155

apexskier opened this issue May 22, 2021 · 2 comments · Fixed by #156

Comments

@apexskier
Copy link
Contributor

I'm attempting to use this workflow after being triggered by workflow_run, as described in https://securitylab.github.com/research/github-actions-preventing-pwn-requests/.

However, I get the error invalid event type: workflow_run (from here).

You can see how I'm using this at https://github.com/apexskier/nova-json-language-server/blob/ea98f31ada6c0a0561bfbee45dc92c2bc621687b/.github/workflows/dependencies.yml.

From what I see in the code, workflow_run could be supported by checking github.event.workflow_run.event and delegating to some of the other executors.
@apexskier
Copy link
Contributor Author

apexskier commented May 22, 2021 •
edited

Just found #144. It looks like the PR that resolved it was for workflow_dispatch, not workflow_run.

apexskier added a commit to apexskier/automerge-action that referenced this issue May 22, 2021
@apexskier
Add support for workflow_run events
333a8e2 
Resolves pascalgn#155

This adds support for `workflow_run` triggered auth-merges. Because
[this event is similar to
`check_suite`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#workflow_run)
I was able to reuse the existing handle check logic.
@apexskier apexskier mentioned this issue May 22, 2021
Merged
pascalgn pushed a commit that referenced this issue May 26, 2021
@apexskier
Add support for workflow_run events (#156)
1f4896c 
Resolves #155

This adds support for `workflow_run` triggered auth-merges. Because
[this event is similar to
`check_suite`](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#workflow_run)
I was able to reuse the existing handle check logic.
@pascalgn
Copy link
Owner

Thanks for the PR, it's merged now! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for workflow_run events apexskier/automerge-action
2 participants
@apexskier @pascalgn