Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the ability to auto-merge an arbitrary pull request #149

Merged
merged 8 commits into from May 11, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Apr 9, 2021

Fixed issue

Fixes #144

Details

This pull request introduces the ability to auto-merge an arbitrary pull request specified via three optional environment variables:

  • PULL_REQUEST_NUMBER
  • GITHUB_OWNER
  • GITHUB_REPO

This will enable automerge-action to be used from a workflow that executes only on the workflow_dispatch event.

Note:
This is my first pull request in this repository, but I did my best to follow the code style and practices that you've established in this repo. Hopefully you find my work high-quality, but if not just let me know and I'll make whatever updates you suggest 馃槃 Thanks for the great work in this repo!

@pascalgn
Copy link
Owner

Sorry for responding so late to this PR!

I think it's fine, but I don't like it too much to have 3 different properties which can only be combined in a specific way. How about instead rename PULL_REQUEST_NUMBER to simply PULL_REQUEST and then let users put either 123 (simple PR number, defaults to the repo the action is running in) or pascalgn/test/123 (full PR specified)

WDYT?

@roryabraham
Copy link
Contributor Author

How about instead rename PULL_REQUEST_NUMBER to simply PULL_REQUEST and then let users put either 123 (simple PR number, defaults to the repo the action is running in) or pascalgn/test/123 (full PR specified)

Yeah, that sounds reasonable to me! I will update this PR soon.

@roryabraham
Copy link
Contributor Author

Okay, this PR is updated and ready for review 馃憤

@roryabraham
Copy link
Contributor Author

@pascalgn friendly reminder that this is ready for review 馃檪 Thanks!

@pascalgn pascalgn merged commit 042e737 into pascalgn:master May 11, 2021
@pascalgn
Copy link
Owner

Sorry for the delay and thanks for the PR, it's merged now! 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can this action support workflow_run?
2 participants