Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't enforce "skipLibCheck: true" #73

Open
parzhitsky opened this issue Jun 3, 2020 · 0 comments
Open

Don't enforce "skipLibCheck: true" #73

parzhitsky opened this issue Jun 3, 2020 · 0 comments
Labels
Domain: main [Issue / PR] describes change in the functionality, its optimization good first issue [Issue] can be addressed by a first-time contributor Pending: blocked [Issue / PR] cannot be addressed until another issue is resolved Pending: unclear [Issue] not yet fully defined Priority: high [Issue / PR] must be addressed as soon as possible Type: bug [Issue / PR] addresses malfunction

Comments

@parzhitsky
Copy link
Member

Follow-up after #69

Current export structure uses @ts-ignore to suppress conflicting export = and export type {}; in src/index.ts, however both are needed to properly support CommonJS's const xrange = require("xrange"); as well as TypeScript's import xrange from "xrange"; syntax.

Unfortunately though, the // @ts-ignore comments is stripped out on build (and it should be frankly), which produces error in node_modules folder of dependent projects. Since there's no way of fixing this error (this would require manually changing code in node_modules), the only (adequate) way to suppress the error is to set skipLibCheck: true compile option.

Find a fix (probably, wait for microsoft/TypeScript#38866 to be implemented) that would remove the requirement of skipLibCheck: true

@parzhitsky parzhitsky added Change: patch [Issue / PR] describes a small non-breaking change, such as bugfix or an optimization Domain: main [Issue / PR] describes change in the functionality, its optimization Pending: blocked [Issue / PR] cannot be addressed until another issue is resolved Priority: high [Issue / PR] must be addressed as soon as possible Type: bug [Issue / PR] addresses malfunction good first issue [Issue] can be addressed by a first-time contributor Pending: unclear [Issue] not yet fully defined and removed Change: patch [Issue / PR] describes a small non-breaking change, such as bugfix or an optimization labels Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: main [Issue / PR] describes change in the functionality, its optimization good first issue [Issue] can be addressed by a first-time contributor Pending: blocked [Issue / PR] cannot be addressed until another issue is resolved Pending: unclear [Issue] not yet fully defined Priority: high [Issue / PR] must be addressed as soon as possible Type: bug [Issue / PR] addresses malfunction
Projects
None yet
Development

No branches or pull requests

1 participant