fix: The client IP address may be determined incorrectly in some cases #8369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request!
|
Codecov ReportBase: 94.12% // Head: 94.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release-5.x.x #8369 +/- ##
=================================================
- Coverage 94.12% 94.12% -0.01%
=================================================
Files 182 182
Lines 13785 13779 -6
=================================================
- Hits 12975 12969 -6
Misses 810 810
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mtrezza
changed the title
This was referenced Jan 5, 2023
parseplatformorg
pushed a commit
that referenced
this pull request
Jan 31, 2023
## [5.4.1](5.4.0...5.4.1) (2023-01-31) ### Bug Fixes * The client IP address may be determined incorrectly in some cases; it is now required to set the Parse Server option `trustProxy` accordingly if Parse Server runs behind a proxy server, see the express framework's [trust proxy](https://expressjs.com/en/guide/behind-proxies.html) setting; this fixes a security vulnerability in which the Parse Server option `masterKeyIps` may be circumvented, see [GHSA-vm5r-c87r-pf6x](GHSA-vm5r-c87r-pf6x) ([#8369](#8369)) ([e016d81](e016d81))
|
🎉 This change has been released in version 5.4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes security vulnerability GHSA-vm5r-c87r-pf6x.