Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with ExJsx dependency #153

Open
julien-leclercq opened this issue Mar 13, 2020 · 10 comments
Open

Problem with ExJsx dependency #153

julien-leclercq opened this issue Mar 13, 2020 · 10 comments

Comments

@julien-leclercq
Copy link

Hello !

Would you be encline to accept a patch to allow usage of json toolkit other than exjsx ?

In several repo where I work (@fewlinesco) we have rabbitmq clients dependencies blocked because it requires a later version of jsx which is unable to install because exjsx has a too early dependency on jsx. I am asking you and not exjsx because there was no commits for 3 years on exjsx.

What I plan to do is forking exvcr and make the stuff so it can use Jason for exemple instead of exjsx. This would allow us to get rid of this outdated dependency. If you are okay with that, I will provide the PR.
@julien-leclercq julien-leclercq mentioned this issue Mar 18, 2020
Closed
@tverlaan
Copy link

Hi @julien-leclercq , I'm running into the same issue but I see your PR was never merged and you closed it. What did you do to solve it? (or perhaps you didn't?)

To the owner, what kind of PR would you accept for this issue?

I'd appreciate any help, thanks :)

@thbar
Copy link
Contributor

thbar commented Jul 6, 2021

I am not the owner, but met the same issue. I'll add more information:

  • exjsx is today marked as This repository has been archived by the owner. It is now read-only..
  • ex_aws (commonly used) enforces jsx ~> 3.0, where exjsx is enforcing jsx -> 2.8.0, so having ExVCR onboard now means one cannot upgrade to latest ex_aws.
Failed to use "jsx" because
  ex_aws (versions 2.2.0 to 2.2.3) requires ~> 3.0
  exjsx (version 4.0.0) requires ~> 2.8.0

So at this point using exvcr in a project blocks the upgrade of a production library.

Happy to help if possible!

@thbar
Copy link
Contributor

thbar commented Jul 6, 2021

I wonder if one path could be to "just" stop using exjsx and instead use jsx directly (or alternatively, use a configurable back-end like started in #154).

thbar added a commit to etalab/transport-site that referenced this issue Jul 6, 2021
@thbar
Explain why we cannot upgrade yet (parroty/exvcr#153)
34c5439
@thbar thbar mentioned this issue Jul 6, 2021
Merged
fchabouis pushed a commit to etalab/transport-site that referenced this issue Jul 7, 2021
@thbar
Mise à jour de ex_aws et + pour compatibilité Elixir 1.11+ (#1703)
08fe1dc 
* Remove left-over from #1616

The db app does not use ex_aws directly anymore.

* Do partial upgrade for ex_aws, ex_aws_s3 and sweet_xml

* Bump up meck and mock

* Bump up exvcr

* Explain why we cannot upgrade yet (parroty/exvcr#153)
@jherdman
Copy link
Contributor

I ran into this problem today. Is there anything we can do to help here?

@swissbeats93
Copy link

I'm having the same problem. Is there any hope that this will be updated?

jherdman added a commit to jherdman/exvcr that referenced this issue Aug 28, 2021
@jherdman
Use Jason Instead of JSX
0162dca 
Given that the broader Elixir community is circling their wagons around
Jason, and issue parroty#153, it seems that moving to Jason would be a wise
choice.
@jherdman jherdman mentioned this issue Aug 28, 2021
Open
@jherdman
Copy link
Contributor

I started #179 this morning. I wouldn't mind a little help with some of the test failures.

jherdman added a commit to jherdman/exvcr that referenced this issue Aug 29, 2021
@jherdman
Use Jason Instead of JSX
99a655e 
Given that the broader Elixir community is circling their wagons around
Jason, and issue parroty#153, it seems that moving to Jason would be a wise
choice.
jherdman added a commit to jherdman/exvcr that referenced this issue Aug 29, 2021
@jherdman
Use Jason Instead of JSX
2eeff29 
Given that the broader Elixir community is circling their wagons around
Jason, and issue parroty#153, it seems that moving to Jason would be a wise
choice.
jherdman added a commit to jherdman/exvcr that referenced this issue Aug 29, 2021
@jherdman
Use Jason Instead of JSX
b3396e6 
Given that the broader Elixir community is circling their wagons around
Jason, and issue parroty#153, it seems that moving to Jason would be a wise
choice.
jherdman added a commit to jherdman/exvcr that referenced this issue Aug 29, 2021
@jherdman
Use Jason Instead of JSX
018adbd 
Given that the broader Elixir community is circling their wagons around
Jason, and issue parroty#153, it seems that moving to Jason would be a wise
choice.
jherdman added a commit to jherdman/exvcr that referenced this issue Sep 6, 2021
@jherdman
Use Jason Instead of JSX
0f2d587 
Given that the broader Elixir community is circling their wagons around
Jason, and issue parroty#153, it seems that moving to Jason would be a wise
choice.
@fmmatheus
Copy link

Also having the same problem. Any updates?

@jherdman
Copy link
Contributor

Nope! I'm a bit stuck on what to do here, and have had a lack of time to resolve the remaining issue. As far as I can tell the remaining failure requires some modification to how we record headers. I believe they need to be encoded using something like base 64 before we write them to a String. Give the PR a whirl. I'm happy to have some help 😄

@AntoineAugusti AntoineAugusti mentioned this issue Sep 29, 2021
Closed
@thbar
Copy link
Contributor

thbar commented Mar 8, 2022

FWIW, ex_aws has relaxed its dependency on JSX, reducing the trouble a bit for us (and maybe for others!) ex-aws/ex_aws#827

@ffloyd
Copy link

ffloyd commented Jun 16, 2022

Any update here? Rabbit libraries focus on 3.0 jsx version so I cannot use VCR with rabbit. =(

ruslandoga added a commit to ruslandoga/exvcr that referenced this issue Jun 23, 2023
@ruslandoga
Use Jason Instead of JSX
8565587 
Given that the broader Elixir community is circling their wagons around
Jason, and issue parroty#153, it seems that moving to Jason would be a wise
choice.
ruslandoga pushed a commit to ruslandoga/exvcr that referenced this issue Jun 23, 2023
@jherdman @ruslandoga
Use Jason Instead of JSX
065ac71 
Given that the broader Elixir community is circling their wagons around
Jason, and issue parroty#153, it seems that moving to Jason would be a wise
choice.
@ruslandoga ruslandoga mentioned this issue Aug 24, 2023
Open
2 tasks
riverrun pushed a commit to riverrun/exvcr that referenced this issue Dec 6, 2023
@jherdman @riverrun
Use Jason Instead of JSX
a0120a9 
Given that the broader Elixir community is circling their wagons around
Jason, and issue parroty#153, it seems that moving to Jason would be a wise
choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jherdman @thbar @ffloyd @tverlaan @julien-leclercq @fmmatheus @swissbeats93