Enforce match on :hackney.request/1, /2, /3 and /4 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes parroty#144. When calling either of ```elixir :hackney.head(url) :hackney.request(:head, url) ``` no request is matched in the `target_methods/1` call, due to the fact that in Hackney `head` function calls in hackney don't call the `body` function. As a result, when making `:hackney.head/1` calls, the request hits the destination instead of being captured.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144.
When calling either of
no request is matched in the
target_methods/1call, due to the factthat in Hackney
headfunction calls in hackney don't call thebodyfunction.
As a result, when making
:hackney.head/1calls, the request hitsthe destination instead of being captured.
I'm not sure if this is the best option to do so, but adding defaults seemed a sensible option.