Improve logging for a case with the missing source file #295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose more granular logging for the case when module's source file does not exist.
Problem
Recently we faced the issue with our CI sometimes producing wrong reports.
All compiled
.beam
files store the absolute path to the source of the module (which is accessed viamodule_info
). We useGitLab
for our CI and by default it checkout the source code with the following pattern:From one runner to another the absolute path is different. With caching in place new runner was pointing to the wrong address (which was correct on other machine).
Outline
There is nothing wrong with the library itself but I believe more explicit logging message would've helped us to spot the issue faster.
Initially, I made a wrong assumption that there is a problem with accessing
module_info
function (since I saw the source files being in place) and went wrong direction.Same issue described in here.
Let me know if that make sense or you need more information on the problem itself.