Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging for a case with the missing source file #295

Merged
merged 1 commit into from Nov 27, 2022

Conversation

thgala
Copy link
Contributor

@thgala thgala commented Nov 24, 2022

I would like to propose more granular logging for the case when module's source file does not exist.

Problem

Recently we faced the issue with our CI sometimes producing wrong reports.

All compiled .beam files store the absolute path to the source of the module (which is accessed via module_info). We use GitLab for our CI and by default it checkout the source code with the following pattern:

{builds_dir}/$RUNNER_TOKEN_KEY/$CONCURRENT_ID/$NAMESPACE/$PROJECT_NAME

From one runner to another the absolute path is different. With caching in place new runner was pointing to the wrong address (which was correct on other machine).

Outline

There is nothing wrong with the library itself but I believe more explicit logging message would've helped us to spot the issue faster.

Initially, I made a wrong assumption that there is a problem with accessing module_info function (since I saw the source files being in place) and went wrong direction.

Same issue described in here.


Let me know if that make sense or you need more information on the problem itself.

@parroty parroty merged commit 09c93ad into parroty:master Nov 27, 2022
@parroty
Copy link
Owner

parroty commented Nov 27, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants