Allows flag_name to pass thru to the coveralls.io API #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parroty
reviewed
Oct 1, 2022
|
Sorry, I merged |
jekku
force-pushed
the
feature/flag_name_to_api
branch
from
655ab03
to
348fd9e
Compare
jekku
force-pushed
the
feature/flag_name_to_api
branch
from
348fd9e
to
b07c6f5
Compare
|
Sorted the feedback and fixed the merge conflicts. :) Thanks again for taking a look |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's here?
We think flag_name is a nice addition to the payload, given that it's a very good organisation tool to sort out your coveralls in groups. Or just get them tagged with anything you want in general for grouping purposes.