Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow subdir and rootdir to be applied to all tasks and always apply to paths #289

Merged
merged 1 commit into from Oct 1, 2022

Conversation

SamHutchings
Copy link
Contributor

Hi,

TL;DR This PR allows the subdir and rootdir options to be used for all types of coverage generation, and always applies the option to the file paths, whether the umbrella flag is true or not.

The context for the change is that we (@duffelhq) have an umbrella application, but during CI runs tests for each app are run in parallel using mix cmd. We wanted to be able to append the app path (e.g. apps/example) to the relative path (e.g. lib/file.exs). However, this option was only available when using coveralls.post, so this PR allows it for all types. We use CircleCI, but I reckon this'd be useful for any CI server, and even when using json or local.

The subdir and rootdir were also previously only used when passing the umbrella flag - I've also made an update to respect these flags whether using umbrella or not.

Any suggestions on alternative methods welcome - I did consider incuding another setting, something like base_reporting_path, but it seemed like subdir/rootdir were what I was looking for. I may be missing some context, however.

@coveralls
Copy link

coveralls commented Oct 1, 2022

Coverage Status

Coverage decreased (-0.02%) to 90.467% when pulling 7665099 on duffelhq:always-allow-subdir-rootdir into d715fb2 on parroty:master.

@parroty parroty merged commit f8b4d0e into parroty:master Oct 1, 2022
@parroty
Copy link
Owner

parroty commented Oct 1, 2022

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants