Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a task to upload coverage from gitlab #240

Merged
merged 1 commit into from Dec 21, 2020

Conversation

ggpasqualino
Copy link
Contributor

Hi there,
I see the example uses the native coverage of GitLab.
I would like to use coveralls though because of the parallel feature.
What do you think? Would it make sense to add that?

Cheers

@parroty
Copy link
Owner

parroty commented Dec 20, 2020

Thanks for the PR. If it does not affect the existing behavior, it may make sense to add the capability, but could I request some description (or reference) regarding the usage? (or any sample would be helpful).

@ggpasqualino
Copy link
Contributor Author

@parroty awesome :)
I have made this demo repo to describe the usage https://gitlab.com/ggpasqualino/excoveralls-demo/

@parroty
Copy link
Owner

parroty commented Dec 21, 2020

Thanks for providing example.

  • Please let me ask how the token (COVERALLS_REPO_TOKEN) is being passed for your demo repository?
    • It's configured as part of GitHub CI settings? (I'm trying to fork the repository to my account and checking the behavior).
  • Can I fork (or link the) demo repository to put the reference in the README?

@ggpasqualino
Copy link
Contributor Author

Thanks for providing example.

  • Please let me ask how the token (COVERALLS_REPO_TOKEN) is being passed for your demo repository?

    • It's configured as part of GitHub CI settings? (I'm trying to fork the repository to my account and checking the behavior).

Yes, you can find the place to set it up under https://gitlab.com/ggpasqualino/excoveralls-demo/-/settings/ci_cd#Variables just replace my user with yours :)

  • Can I fork (or link the) demo repository to put the reference in the README?

Yes, for sure you may fork it and link it in the README

@parroty parroty merged commit 4fa7517 into parroty:master Dec 21, 2020
@parroty
Copy link
Owner

parroty commented Dec 21, 2020

Thanks for the clarifications. I've updated the reference as https://gitlab.com/parroty/excoveralls-demo/ (also added small note about COVERALLS_REPO_TOKEN environment variable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants