Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed issue #1

Open
ttonyh opened this issue Dec 5, 2023 · 3 comments
Open

Speed issue #1

ttonyh opened this issue Dec 5, 2023 · 3 comments

Comments

@ttonyh
Copy link

ttonyh commented Dec 5, 2023

Great idea to extract the functionality into a separate module. The speed though is painful. Do you know what's causing it and if it's possible to speed it up?

@paro-paro
Copy link
Owner

paro-paro commented Dec 6, 2023

Hi @ttonyh

Have you tried latests nuxt 3.8.1 and 3.8.2 versions? I believe the nuxt warm up time has being reduced on those versions: here

Running the basic playground/nuxt app from the repo I get > 8 seconds on nuxt 3.7.4 and 3.8.0 (which is definitely very bad since the app is just a single button...)

Screenshot 2023-12-06 at 14 37 53 Screenshot 2023-12-06 at 14 47 15

But now, on 3.8.1 and 3.8.2, the warm up time is down to around 2.7 secs (which might not be the best but is an improvement).

Screenshot 2023-12-06 at 14 52 32 Screenshot 2023-12-06 at 14 57 20

Of course, this plugin is just a copy/pasted version of the original that adds support for nuxt-ssr but does not includes any performance related improvements. And I have not stress-tested the plugin either in a real production grade app (with many components).

So, as far as I know, there are a few upstream issues that might be affecting:

  • SASS compilation with vite (that currently leverages the 'sass' package compiler) seems to be slow. You can go through vite's issues/discussions for more details: link link link

  • The nuxt-specific warm up issue. But this seems that has being fixed already in the two latest versions.

@ttonyh
Copy link
Author

ttonyh commented Dec 6, 2023

Hi @paro-paro ,

Thanks for the quick response and all the info/links. I'm on the following version: Nuxt 3.8.2 with Nitro 2.8.1. It has been a quite a journey trying to get the Vuetify SCSS / Loader / Vite thing working well in DEV, but I have confidence we're nearing the finish line. Thanks again for this very helpful module!

@BayBreezy
Copy link

Thanks for the plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants