Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RPC call to get account nonce #476

Merged
merged 4 commits into from Mar 14, 2022
Merged

Use RPC call to get account nonce #476

merged 4 commits into from Mar 14, 2022

Conversation

jsdw
Copy link
Collaborator

@jsdw jsdw commented Mar 14, 2022 •
edited

This great suggestion from #474 allows us to remove a bunch of code around getting the account nonce from storage.

Closes #474

ascjones
ascjones approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. 🎉

niklasad1
niklasad1 approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat 👍

@lemarier
Copy link
Contributor

Thanks! 🚀

@jsdw jsdw merged commit 8b19549 into master Mar 14, 2022
@jsdw jsdw deleted the jsdw-nonce-rpc branch March 14, 2022 15:39
@jsdw jsdw mentioned this pull request Mar 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of system_accountNextIndex as nonce
5 participants
@jsdw @lemarier @ascjones @niklasad1 @lexnv