Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.3.0 #170

Merged
merged 10 commits into from Oct 31, 2022
Merged

Release v2.3.0 #170

merged 10 commits into from Oct 31, 2022

Conversation

xermicus
Copy link
Member

@xermicus xermicus commented Oct 26, 2022

This PR should make #164 non-breaking and prepare for the next release.

Signed-off-by: xermicus <bigcyrill@hotmail.com>
Signed-off-by: xermicus <bigcyrill@hotmail.com>
@xermicus
Copy link
Member Author

@ascjones was there a specific reason why we removed the impl IntoPortable for &'static str? Looks like this makes it a breaking change

@xermicus
Copy link
Member Author

xermicus commented Oct 27, 2022

use-ink/ink#1452 ✔️

@xermicus xermicus requested a review from jsdw October 27, 2022 14:22
src/build.rs Show resolved Hide resolved
Copy link
Member

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for you to go ahead and release this providing substrate and ink still compile with no changes.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Andrew Jones <ascjones@gmail.com>
@xermicus
Copy link
Member Author

Happy for you to go ahead and release this providing substrate and ink still compile with no changes.

Substrate and ink still compile for me locally when I patch it. Should we wait for some substrate CI runs?

paritytech/substrate#12578

@ascjones
Copy link
Member

Happy for you to go ahead and release this providing substrate and ink still compile with no changes.

Substrate and ink still compile for me locally when I patch it. Should we wait for some substrate CI runs?

paritytech/substrate#12578

Fine by me if it works locally for you. Feel free to go ahead and cargo publish, then we can merge this.

@xermicus xermicus changed the title Next release Release v2.3.0 Oct 30, 2022
@xermicus xermicus requested a review from athei October 31, 2022 09:41
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xermicus xermicus merged commit ad90cb1 into master Oct 31, 2022
@xermicus xermicus deleted the cl/next-release branch October 31, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants