Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI tests for crate renaming #146

Closed
jsdw opened this issue Mar 14, 2022 · 0 comments · Fixed by #147
Closed

Add UI tests for crate renaming #146

jsdw opened this issue Mar 14, 2022 · 0 comments · Fixed by #147

Comments

@jsdw
Copy link
Contributor

jsdw commented Mar 14, 2022

#145 adds the ability to tell scale-info where the crate lives, which is super handy in some circumstances.

let's add a couple of UI tests for this feature.

Potentially we can rename scale-info in the test Cargo.toml and then use foo::{self as scale_info}; at the top of most tests to expose it in the "usual place", and then we can fully test that #[scale_info(crate = "foo")] works when it is only present under eg foo::.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant