-
Notifications
You must be signed in to change notification settings - Fork 40
Multiple errors on sync #95
Comments
Cool, thanks for reporting! :) This isn't normal, but I don't see how we could avoid this. I have also noted this recently (#58) - there are too many peers from other blockchains (here: zel.cash with its Logging the peer disconnect reason is a good option, imo. Otherwise you'll never see why your client stays unsynced && it is even more weirder (getting multiple I'll leave this issue open for a bit - probably someone will have an idea of how to improve peer selection strategy. |
While a Zel node, misconfigured via an explicit 'addnode' could be reaching to a Zcash one, it is unlikely, as the default port numbers are very different (16125). Though possible, we have no indication that the Zcash node would then accept lists of more Zel peers, and worse yet pass them onto other Zcash nodes. Definitely would not be able to validate and pass on a Zel transaction or block. Looks like after a while you start erroring out and disconnecting just about every peer#. Likely you get yourself into a state where you reject valid peers and then run out of peers (you call this state saturated, though likely you mean exhausted). Does feel like more than just some annoying messages in the log file, but perhaps a stateful bug. Wonder if your peer list somehow getting polluted or filled-up. Would help to see some peer info details, to understand what those peers are and whether you are cycling through a small set of peers, e.g. Zcash: After a quick look at the code, do wonder about the implementation of remove(), misbehaving(), dos() in synchronization_peers.rs, PeersContainer for PeersImpl: BTW, where in the code are you disconnecting during sync peers with fewer blocks than you have already? |
When started with empty database, parity-zcash connects to hardcoded set of seed nodes. The seednodes are the same as in original zcash client. That's the only way to get set of peers. So zel.cash peers are the peers we receive from seednodes (or from nodes that seednodes have provided us with).
I haven't seen any case where we disconnect from valid peers. Could you, please, file a separate issue with detailed logs (
I could confirm that last time I've checked this, zel.cash peers were responding with
There's no such code atm.
Limits are currently hardcoded to 10 inbound and 10 outbound connections. |
I have finally imported the blockchain :)
Now, when I run pzec, I see multiple errors.
Is this normal?
The text was updated successfully, but these errors were encountered: